-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
StratifiedGroupShuffleSplit and StratifiedGroupKFold #15239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
hermidalc
wants to merge
9
commits into
scikit-learn:main
from
hermidalc:stratified-groupshufflesplit
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4df86c6
Initial implementation
hermidalc 6be3594
Forgot to add to second __add__ list
hermidalc 2f28673
Update split method parameter doc
hermidalc 2365735
Added example; changed default test_size to 0.1; added to author list
hermidalc b3d2b5a
Merge branch 'master' of github.com:scikit-learn/scikit-learn into st…
hermidalc aa8f288
StratifiedGroupKFold impl and other improvements
hermidalc 647a97e
Add class to __all__ spec
hermidalc 36babe5
Remove random_state when no shuffle
hermidalc 32e502a
Tighter formatting
hermidalc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this sentence. What do you mean by "folds not being different"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That text is copied from
StratifiedShuffleSplit
and the meaning behind it is that shuffle splitting does not guarantee that each split will be different than another.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. I think in sklearn we call folds the partitions in the split, not the repetitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think partitions/splits/folds that's what is meant here and I believe in
StratifiedShuffleSplit
. With randomized splits there is no guarantee that a partition will be different than other ones.