8000 DOC improve documentation of GradientBoosting.oob_improvement_ by samsaara · Pull Request #15204 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC improve documentation of GradientBoosting.oob_improvement_ #15204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2019
Merged

DOC improve documentation of GradientBoosting.oob_improvement_ #15204

merged 1 commit into from
Oct 13, 2019

Conversation

samsaara
Copy link
Contributor
@samsaara samsaara commented Oct 12, 2019 •
edited by rth
Loading

Reference Issues/PRs

Closes #15025

What does this implement/fix? Explain your changes.

the attribute oob_improvement_ in base class BaseGradientBoosting is available only when subsample < 1. So update the docstring to inform the user about it.

This is just a 2 line change in docstrings

@samsaara samsaara changed the title DOC minor updates for atribute docs in GradientBoosting DOC minor updates for attribute docs in GradientBoosting Oct 12, 2019
rth
rth approved these changes Oct 13, 2019
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rth rth changed the title DOC minor updates for attribute docs in GradientBoosting DOC improve documentation of GradientBoosting.oob_improvement_ Oct 13, 2019
@rth rth merged commit a59562d into scikit-learn:master Oct 13, 2019
@samsaara samsaara deleted the fix_doc_oob_improvement branch October 14, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Attributes for GradientBoostingClassifier should not include oob_improvement
3 participants
@samsaara @rth @thomasjpfan
0