8000 [MRG] BUILD: avoid displaying OpenMP error message when irrelevant by jeremiedbb · Pull Request #15172 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] BUILD: avoid displaying OpenMP error message when irrelevant #15172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[MRG] BUILD: avoid displaying OpenMP error message when irrelevant #15172

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8e65e19
first compile a first test programm not using openmp to avoid display…
jeremiedbb Oct 10, 2019
f37ca84
cln
jeremiedbb Oct 10, 2019
28c512e
debug
jeremiedbb Oct 10, 2019
e1d50a7
debug
jeremiedbb Oct 10, 2019
8842f53
fix
jeremiedbb Oct 10, 2019
a950dad
cln
jeremiedbb Oct 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
130 changes: 87 additions & 43 deletions sklearn/_build_utils/openmp_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,16 @@


CCODE = textwrap.dedent(
"""\
#include <stdio.h>
int main(void) {
printf("success\\n");
return 0;
}
""")


CCODE_OPENMP = textwrap.dedent(
"""\
#include <omp.h>
#include <stdio.h>
Expand All @@ -28,6 +38,63 @@
""")


def compile_test_program(code, extra_preargs=[], extra_postargs=[]):
"""Check that some C code can be compiled and run"""
ccompiler = new_compiler()
customize_compiler(ccompiler)

# extra_(pre/post)args can be a callable to make it possible to get it's
# value from the compiler
if callable(extra_preargs):
extra_preargs = extra_preargs(ccompiler)
if callable(extra_postargs):
extra_postargs = extra_postargs(ccompiler)

start_dir = os.path.abspath('.')

with tempfile.TemporaryDirectory() as tmp_dir:
os.chdir(tmp_dir)

# Write test program
with open('test_program.c', 'w') as f:
f.write(code)

os.mkdir('objects')

# Compile, test program
ccompiler.compile(['test_program.c'], output_dir='objects',
extra_postargs=extra_postargs)

# Link test program
objects = glob.glob(
os.path.join('objects', '*' + ccompiler.obj_extension))
ccompiler.link_executable(objects, 'test_program',
extra_preargs=extra_preargs,
extra_postargs=extra_postargs)

# Run test program
output = subprocess.check_output('./test_program')
output = output.decode(sys.stdout.encoding or 'utf-8').splitlines()

os.chdir(start_dir)

return output


def basic_check_build():
"""Check basic compilation and linking of C code"""
try:
output = compile_test_program(CCODE)
if "success" in output[0]:
compiler_ok = True
else:
compiler_ok = False
except (CompileError, LinkError, subprocess.CalledProcessError):
compiler_ok = False

return compiler_ok


def get_openmp_flag(compiler):
if hasattr(compiler, 'compiler'):
compiler = compiler.compiler[0]
Expand Down Expand Up @@ -59,59 +126,36 @@ def get_openmp_flag(compiler):

def check_openmp_support():
"""Check whether OpenMP test code can be compiled and run"""
ccompiler = new_compiler()
customize_compiler(ccompiler)

if os.getenv('SKLEARN_NO_OPENMP'):
# Build explicitly without OpenMP support
return False

start_dir = os.path.abspath('.')
if not basic_check_build():
# simple build without OpenMP fails. No need to check OpenMP (avoids
# possible wrong interpretation of error message)
return False

with tempfile.TemporaryDirectory() as tmp_dir:
try:
os.chdir(tmp_dir)

# Write test program
with open('test_openmp.c', 'w') as f:
f.write(CCODE)

os.mkdir('objects')

# Compile, test program
openmp_flags = get_openmp_flag(ccompiler)
ccompiler.compile(['test_openmp.c'], output_dir='objects',
extra_postargs=openmp_flags)

# Link test program
extra_preargs = os.getenv('LDFLAGS', None)
if extra_preargs is not None:
extra_preargs = extra_preargs.split(" ")
else:
extra_preargs = []

objects = glob.glob(
os.path.join('objects', '*' + ccompiler.obj_extension))
ccompiler.link_executable(objects, 'test_openmp',
extra_preargs=extra_preargs,
extra_postargs=openmp_flags)
extra_preargs = os.getenv('LDFLAGS', None)
if extra_preargs is not None:
extra_preargs = extra_preargs.split(" ")
else:
extra_preargs = []

# Run test program
output = subprocess.check_output('./test_openmp')
output = output.decode(sys.stdout.encoding or 'utf-8').splitlines()
extra_postargs = get_openmp_flag

# Check test program output
if 'nthreads=' in output[0]:
nthreads = int(output[0].strip().split('=')[1])
openmp_supported = (len(output) == nthreads)
else:
openmp_supported = False
try:
output = compile_test_program(CCODE_OPENMP,
extra_preargs=extra_preargs,
extra_postargs=extra_postargs)

except (CompileError, LinkError, subprocess.CalledProcessError):
if 'nthreads=' in output[0]:
nthreads = int(output[0].strip().split('=')[1])
openmp_supported = (len(output) == nthreads)
else:
openmp_supported = False

finally:
os.chdir(start_dir)
except (CompileError, LinkError, subprocess.CalledProcessError):
openmp_supported = False

err_message = textwrap.dedent(
"""
Expand Down
0