8000 TST Skip some doctests if pillow not installed by rth · Pull Request #15131 · scikit-learn/scikit-learn · GitHub < 8000 meta name="browser-stats-url" content="https://api.github.com/_private/browser/stats">
[go: up one dir, main page]
Skip to content

TST Skip some doctests if pillow not installed #15131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomasjpfan merged 2 commits into from
Oct 7, 2019
Merged

TST Skip some doctests if pillow not installed #15131

thomasjpfan merged 2 commits into from
Oct 7, 2019

Conversation

@rth
Copy link
Member
@rth rth commented Oct 4, 2019

Currently if pillow (or PIL) is not installed some doctests in sklearn.feature_extraction.image would fails.

I kept running into this while running the test suite in a new environment. Failing because pillow is not installed is not ideal.

This PR skips those 2 doctests in that case with an appropriate message.

@thomasjpfan
Copy link
Member
thomasjpfan commented Oct 4, 2019

If there is another pillow dependent doctest, we would need to remember to add it to this list because the CI installs Pillow by default. I guess we can run the doctest on an instance that does not have pillow installed.

@rth
Copy link
Member Author
rth commented Oct 7, 2019

OK, I removed the installation of pillow in pylatest_pip_openblas_pandas since an equivalent setup is already tested in pylatest_conda_mkl.

ogrisel
ogrisel approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit fdbaa58 into scikit-learn:master Oct 7, 2019
@thomasjpfan
Copy link
Member
thomasjpfan commented Oct 7, 2019

Thank you @rth !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ogrisel ogrisel ogrisel approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rth @thomasjpfan @ogrisel
0