8000 DOC Sphinx Unexpected unindent warnings by cmarmo · Pull Request #15130 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC Sphinx Unexpected unindent warnings #15130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2019

Conversation

cmarmo
Copy link
Contributor
@cmarmo cmarmo commented Oct 4, 2019

What does this implement/fix? Explain your changes.

This PR fixes a new bunch of Sphinx warnings (about blank lines and unexpected unindent).

Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fixes.

@@ -168,8 +168,8 @@ def _fit_transform(self, X):
self.embedding_ = self.kernel_pca_.fit_transform(G)

8000
@property
@deprecated("Attribute training_data_ was deprecated in version 0.22 and "
"will be removed in 0.24.")
@deprecated("Attribute `training_data_` was deprecated in version 0.22 and"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty weird thing to warn about. The training_data_ links: https://scikit-learn.org/dev/modules/generated/sklearn.manifold.Isomap.html#id5

@thomasjpfan thomasjpfan merged commit 871b251 into scikit-learn:master Oct 4, 2019
@cmarmo cmarmo deleted the warningsphinx branch October 7, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0