8000 [MRG] MNT deprecate some more utils in estimator_checks.py by NicolasHug · Pull Request #15029 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] MNT deprecate some more utils in estimator_checks.py #15029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 20, 2019
Merged

[MRG] MNT deprecate some more utils in estimator_checks.py #15029

merged 6 commits into from
Sep 20, 2019

Conversation

NicolasHug
Copy link
Member
@NicolasHug NicolasHug commented Sep 19, 2019 •
edited
Loading

Addresses part of #6616

This PR deprecates

  • sklearn.utils.estimator_checks.NotAnArray
  • sklearn.utils.estimator_checks.is_public_parameter
  • sklearn.utils.estimator_checks.pairwise_estimator_convert_X
  • sklearn.utils.estimator_checks.set_checking_parameters

@NicolasHug NicolasHug changed the title [NOMRG] deprecates some utils [MRG] MNT deprecate some more utils in estimator_checks.py Sep 19, 2019
amueller
amueller reviewed Sep 19, 2019
View reviewed changes
sklearn/utils/estimator_checks.py Outdated
@@ -520,6 +526,21 @@ def set_checking_parameters(estimator):


class NotAnArray:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use @deprecated?

amueller
amueller reviewed Sep 19, 2019
View reviewed changes
Copy link
Member
@amueller amueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why you'd copy the implementation of NotAnArray, other than that looks good.

@thomasjpfan
Copy link
Member

Add to the Recently deprecated section in classes.rst?

@NicolasHug
< 9EC6 div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="bae9bf7d75efba1b88184f6ba24858c49650ab1d73b16d47a302dff3beabd369">
Copy link
Member Author

None of them is in the API ref @thomasjpfan I see no reason to add them now

@adrinjalali adrinjalali merged commit 70f9e9f into scikit-learn:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amueller amueller amueller approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NicolasHug @thomasjpfan @amueller @adrinjalali
0