8000 [MRG] Make dbscan call DBSCAN.fit by NicolasHug · Pull Request #14994 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] Make dbscan call DBSCAN.fit #14994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2019
Merged

[MRG] Make dbscan call DBSCAN.fit #14994

merged 1 commit into from
Sep 18, 2019

Conversation

NicolasHug
Copy link
Member

This PR make dbscan call DBSCAN.fit instead of the reverse. API and tests are unchanged.

Side note, check_array was called twice here.

@qinhanmin2014
Copy link
Member

Again, can we make dbscan and k_means private?

@NicolasHug
Copy link
Member Author

I want too but this is out of scope for this PR and the discussion is at #14897

This PR would make it very easy to deprecate.

@TomDLT TomDLT merged commit c56bce4 into scikit-learn:master Sep 18, 2019
@jeremiedbb jeremiedbb mentioned this pull request Dec 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomDLT TomDLT TomDLT approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @qinhanmin2014 @TomDLT
0