8000 EHN update lobpcg from scipy master by glemaitre · Pull Request #14971 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

EHN update lobpcg from scipy master #14971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2019
Merged

EHN update lobpcg from scipy master #14971

merged 3 commits into from
Sep 16, 2019

Conversation

glemaitre
Copy link
Member

The version of lobpcg in scipy has recently benefited from some bug fixes.
We should update the version that we have in master.

@ogrisel
Copy link
Member
ogrisel commented Sep 13, 2019

LGTM but maybe we should add a non-regression test for the bugs that are fixed by this backport?

ogrisel
ogrisel approved these changes Sep 13, 2019
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The non-regression test is not mandatory: it's better to keep in sync than not anyway as I assume scipy has its own tests and I do not want to delay this PR.

@glemaitre
Copy link
Member Author

The non-regression test is not mandatory: it's better to keep in sync than not anyway as I assume scipy has its own tests and I do not want to delay this PR.

+1 on this. If we see any additional thing to test, we should make it upstream.

rth
rth approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rth rth changed the title [MRG] EHN update lobpcg from scipy master EHN update lobpcg from scipy master Sep 16, 2019
@rth rth merged commit 2e8ce31 into scikit-learn:master Sep 16, 2019
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Sep 16, 2019
@glemaitre
EHN update lobpcg from scipy master (scikit-learn#14971)
c289e27
@jnothman jnothman mentioned this pull request Oct 28, 2019
Closed
8 tasks
@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glemaitre @ogrisel @rth
0