8000 [MRG] Add memory measurements in gallery by lesteve · Pull Request #14532 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] Add memory measurements in gallery #14532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2019
Merged

[MRG] Add memory measurements in gallery #14532

merged 1 commit into from
Jul 31, 2019

Conversation

lesteve
Copy link
Member
@lesteve lesteve commented Jul 31, 2019

Since 0.3 sphinx-gallery supports memory measurements in examples on top of timings.

This is how it looks (from sphinx-gallery doc):
image

@lesteve
Copy link
Member Author
lesteve commented Jul 31, 2019

On top of being useful in general, I am curious to see whether most of our examples can fit in 8000 the 1-2 GB of RAM you get on binder (i.e. related to #11221).

@lesteve lesteve force-pushed the use-memory-profiler-in-gallery branch from 36786a4 to 0f7f442 Compare July 31, 2019 11:29
@lesteve lesteve force-pushed the use-memory-profiler-in-gallery branch from 0f7f442 to 6c777e3 Compare July 31, 2019 13:31
@rth
Copy link
Member
rth commented Jul 31, 2019

Interesting. Would the profiling overhead make example generation noticeably slower though? Could you trigger another full docs build without force-pushing?

@lesteve
Copy link
Member Author
lesteve commented Jul 31, 2019 •
edited
Loading

I don't expect memory profiling to have a significant effect on the time needed to run the examples. I found this from the memory_profiler original author that seems to agree.

I guess you can always compare this PR doc timings to the dev doc timings if you are unconvinced.

rth
rth approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, LGTM, thanks!

@rth rth merged commit e23f58d into scikit-learn:master Jul 31, 2019
@lesteve lesteve deleted the use-memory-profiler-in-gallery branch July 31, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lesteve @rth
0