10000 MAINT Mark for removal deprecated LinearSVC loss options in 0.23 by rth · Pull Request #14373 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Mark for removal deprecated LinearSVC loss options in 0.23 #14373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 17, 2019
Merged

MAINT Mark for removal deprecated LinearSVC loss options in 0.23 #14373

merged 4 commits into from
Jul 17, 2019

Conversation

rth
Copy link
Member
@rth rth commented Jul 15, 2019 •
edited
Loading

The l1 / l2 loss options in LinearSVC were renamed to hinge and squared_hinge in 0.16 and marked for removal in 1.0.

Since it's unclear when 1.0 will happen this moves the removal date to 0.23 0.22 0.23.

@rth rth changed the title MAINT Mark for removal deprecated LinearSVC loss options in 0.23 MAINT Mark for removal deprecated LinearSVC loss options in 0.22 Jul 15, 2019
qinhanmin2014
qinhanmin2014 reviewed Jul 15, 2019
View reviewed changes
Copy link
Member
@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe 0.23 or 0.24? since current stable is 0.21.X.

@rth rth changed the title MAINT Mark for removal deprecated LinearSVC loss options in 0.22 MAINT Mark for removal deprecated LinearSVC loss options in 0.23 Jul 15, 2019
@rth
Copy link
Member Author
rth commented Jul 15, 2019

Maybe 0.23 or 0.24? since current stable is 0.21.X.

Yes, of course, thanks. Changed back to 0.23.

qinhanmin2014
qinhanmin2014 approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member
@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.24 and a what's new entry might be less controversial, but I'm OK with current version.

@rth
Copy link
Member Author
rth commented Jul 15, 2019

0.24 and a what's new entry might be less controversial, but I'm OK with current version.

Well it was deprecated in 2015, 0.23 will be in 2020-2021. Other libraries typically deprecate something, then remove it after a while. scikit-learn started to indicate the exact deprecation version not that long ago I imagine, this code should have been removed long time ago.

@glemaitre
Copy link
Member

Could you document it in what's new (under deprecation maybe), such that we easily spot if for removal in the next release?

@rth
Copy link
Member Author
rth commented Jul 16, 2019

Could you document it in what's new (under deprecation maybe)

I can add,

- |API| The "l1" and "l2" options of `loss` parameters in :class:`svm.LinearSVC`,
    :class:`svm.LinearSVR` that were deprecated in v0.16 will be removed in v0.23.
    :pr:`12916` by :user:`Roman Yurchak`_.

but I don't think it makes much sense, because we don't typically make guarantees as to when a deprecated functionality will be removed (simply because we might very well forget to remove it in v0.23). Also the only thing changing in v0.22 is the content of the deprecation message. It's not an API change and mostly irrelevant to current users.

such that we easily spot if for removal in the next release?

Searching for 0.23 is probably a more reliable way of finding deprecations anyway?

@glemaitre
Copy link
Member

Searching for 0.23 is probably a more reliable way of finding deprecations anyway?

Reliable yes but a headache as well :). If everything that should be removed for a version could be documented in a single section, it would ease the search :)

qinhanmin2014
qinhanmin2014 approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member
@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's enough consensus.

@qinhanmin2014 qinhanmin2014 merged commit b0fdc4c into scikit-learn:master Jul 17, 2019
@rth rth deleted the doc-linearsvc branch July 17, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amueller amueller amueller approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rth @glemaitre @amueller @qinhanmin2014
0