-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
MAINT Mark for removal deprecated LinearSVC loss options in 0.23 #14373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe 0.23 or 0.24? since current stable is 0.21.X.
Yes, of course, thanks. Changed back to 0.23. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.24 and a what's new entry might be less controversial, but I'm OK with current version.
Well it was deprecated in 2015, 0.23 will be in 2020-2021. Other libraries typically deprecate something, then remove it after a while. scikit-learn started to indicate the exact deprecation version not that long ago I imagine, this code should have been removed long time ago. |
Could you document it in what's new (under deprecation maybe), such that we easily spot if for removal in the next release? |
I can add,
but I don't think it makes much sense, because we don't typically make guarantees as to when a deprecated functionality will be removed (simply because we might very well forget to remove it in v0.23). Also the only thing changing in v0.22 is the content of the deprecation message. It's not an API change and mostly irrelevant to current users.
Searching for |
Reliable yes but a headache as well :). If everything that should be removed for a version could be documented in a single section, it would ease the search :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's enough consensus.
The l1 / l2 loss options in LinearSVC were renamed to
hinge
andsquared_hinge
in 0.16 and marked for removal in 1.0.Since it's unclear when 1.0 will happen this moves the removal date to
0.230.220.23.