8000 Describe classes_ attribute for GaussianNB, MultinomialNB, etc. by alexitkes · Pull Request #14354 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content
/ scikit-learn Public

Describe classes_ attribute for GaussianNB, MultinomialNB, etc. #14354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2019
Merged

Describe classes_ attribute for GaussianNB, MultinomialNB, etc. #14354

merged 1 commit into from
Jul 14, 2019

Conversation

alexitkes
Copy link
Contributor
@alexitkes alexitkes commented Jul 14, 2019 •
edited by qinhanmin2014
Loading

Partially address #14312

  • GaussianNB [classes_]
    Class labels known to the classifier

  • BernoulliNB [classes_]
    Class labels known to the classifier

  • ComplementNB [classes_]
    Class labels known to the classifier

  • MultinomialNB [classes_]
    Class labels known to the classifier

qinhanmin2014
qinhanmin2014 approved these changes Jul 14, 2019
View reviewed changes
Copy link
Member
@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @alexitkes
partially fixes will still close the issue automatically when the PR is merged.

@alexitkes
Copy link
Contributor Author
alexitkes commented Jul 14, 2019 •
edited
Loading

partially fixes will still close the issue automatically when the PR is merged.

Oh, sorry, I didn't know that. But... why has #14320 been merged properly? A warning was displayed when I started it with "Fixes <issue_number>", but when I wrote "Partially fixes <issue_number>" instead, it disappeared.

Update:

Sorry again, I see - the issue was re-opened.

thomasjpfan
thomasjpfan approved these changes Jul 14, 2019
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit ebf5fa7 into scikit-learn:master Jul 14, 2019
@thomasjpfan
Copy link
Member

Thank you! @alexitkes

@alexitkes alexitkes deleted the alexitkes-naive-bayes branch July 14, 2019 15:34
@judithabk6 judithabk6 mentioned this pull request Jan 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign 64AB in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexitkes @thomasjpfan @qinhanmin2014
0