8000 [WIP] FIX make sure sample_weight has an effect on predictions by glemaitre · Pull Request #14266 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[WIP] FIX make sure sample_weight has an effect on predictions #14266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] FIX make sure sample_weight has an effect on predictions #14266

wants to merge 1 commit into from

Conversation

glemaitre
Copy link
Member

Alternative/complement to #14246

Check that sample_weight change the prediction of the estimator. In case this is not true, it could be because of a bug.

@adrinjalali
Copy link
Member

Have you already checked why those estimators are failing? One would assume some of those failing estimators are definitely okay regarding sample weights, apparently not.

@jnothman
Copy link
Member
jnothman commented Jul 6, 2019 via email

@glemaitre
Copy link
Member Author

Have you already checked why those estimators are failing? One would assume some of those failing estimators are definitely okay regarding sample weights, apparently not.

I am looking at the different models which are failing to understand if this is normal or not.
Once I have a list of explanation we can see if we should have a common test or not.
8000

@glemaitre glemaitre mentioned this pull request Jul 8, 2019
Closed
@amueller amueller added the Needs Decision Requires decision label Aug 6, 2019
@glemaitre glemaitre mentioned this pull request Sep 19, 2019
Closed
14 tasks
@amueller amueller added this to the 0.22 milestone Sep 19, 2019
@ogrisel ogrisel changed the title [WIP] FIX make sure sample_weight as an effect on predictions [WIP] FIX make sure sample_weight has an effect on predictions Oct 7, 2019
@jnothman jnothman modified the milestones: 0.22, 0.23 Oct 31, 2019
@thomasjpfan thomasjpfan modified the milestones: 0.23, 0.24 Apr 20, 2020
@cmarmo cmarmo removed this from the 0.24 milestone Oct 15, 2020
Base automatically changed from master to main January 22, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:utils Needs Decision Requires decision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@glemaitre @adrinjalali @jnothman @amueller @cmarmo @thomasjpfan
0