TST attempt to fix the variance threshold part of #14192 #14204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rth
approved these changes
Jun 27, 2019
| @@ -38,7 +38,9 @@ def test_zero_variance_floating_point_error(): | |||
| # See #13691 | |||
|
|
|||
| data = [[-0.13725701]] * 10 | |||
There was a problem hiding this comment.
Maybe using,
Suggested change
| data = [[-0.13725701]] * 10 | |
| data = np.full((10, 1), -0.13725701) |
would be better anyway?
qinhanmin2014
approved these changes
Jun 27, 2019
|
I think it's a very special piece of functionality and I'd rather have it
tested for non-regression.
|
|
tests fail @jnothman (no ladder on my ipad so can't access azure, sigh...) |
|
Failure in |
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly builds are failing on this assertion (#14192) which was only intended to prove that the test's primary assertion, below it, is actually valid.