8000 MAINT Simplify arguments to csr_set_problem and csr_to_sparse by alexhenrie · Pull Request #14135 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Simplify arguments to csr_set_problem and csr_to_sparse #14135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2019
Merged

MAINT Simplify arguments to csr_set_problem and csr_to_sparse #14135

merged 1 commit into from
Jun 21, 2019

Conversation

alexhenrie
Copy link
Contributor

Their arguments are now more like the arguments to set_problem and
dense_to_sparse.

n_indices (a.k.a. shape_indices) was not being used and n_indptr[0]-1 (a.k.a. shape_indptr[0]-1) is just the number of samples.

@alexhenrie
MAINT Simplify arguments to csr_set_problem and csr_to_sparse
de568cf 
Their arguments are now more like the arguments to set_problem and
dense_to_sparse.
jnothman
jnothman approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member
@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rth rth merged commit cf2e60b into scikit-learn:master Jun 21, 2019
@rth
Copy link
Member
rth commented Jun 21, 2019

Thanks!

@alexhenrie alexhenrie deleted the csr branch July 8, 2019 17:28
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@alexhenrie @koenvandevelde
MAINT Simplify arguments to csr_set_problem and csr_to_sparse (scikit…
a5b0046 
…-learn#14135)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexhenrie @rth @jnothman
0