8000 FIX remove action of normalize_components in SparsePCA by glemaitre · Pull Request #14134 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

FIX remove action of normalize_components in SparsePCA #14134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2019
Merged

FIX remove action of normalize_components in SparsePCA #14134

merged 2 commits into from
Jun 21, 2019

Conversation

glemaitre
Copy link
Member

I forgot to remove the following line when dealing with the deprecation.
Note that normalize_components should not have any effect and the algorithm behave like if normalize_components=True

@glemaitre
Copy link
Member Author

@rth this is an easy one

rth
rth approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe also add SparcePCA to "Changed models" in what's new because as of 0.22 normalize_components is deprecated, still exists and has no effect anymore.

thomasjpfan
thomasjpfan approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The history of this parameter is quite something. We added it in 0.20 (for backwards compatibility) just so we can deprecate it in 0.22.

@glemaitre
Copy link
Member Author

The history of this parameter is quite something. We added it in 0.20 (for backwards compatibility) just so we can deprecate it in 0.22.

Actually we added it to keep a backwards compatibility that was certainly a bug :)

@thomasjpfan thomasjpfan merged commit e94f5de into scikit-learn:master Jun 21, 2019
@thomasjpfan
Copy link
Member

Thank you! @glemaitre

koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@glemaitre @koenvandevelde
FIX remove action of normalize_components in SparsePCA (scikit-learn#…
566cebc 
…14134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glemaitre @thomasjpfan @rth
0