8000 Fixed typo in test_column_transformer by lrjball · Pull Request #14128 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

Fixed typo in test_column_transformer #14128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Fixed typo in test_column_transformer #14128

merged 1 commit into from
Jun 20, 2019

Conversation

lrjball
Copy link
Contributor
@lrjball lrjball commented Jun 19, 2019

Reference Issues/PRs

Was original part of #14048, but have separated it into its own PR.

What does this implement/fix? Explain your changes.

In test_column_transformer_dataframe(), X_df2 was created but never used. X_df was mistakenly used in its place. This PR fixes that typo.

In test_column_transformer_dataframe(), X_df2 was created but never used. X_df was mistakely being used in its place. The PR fixes that typo.
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The original comment by Joris was in #14048 (comment)

@jnothman jnothman merged commit 0c11070 into scikit-learn:master Jun 20, 2019
@jnothman
Copy link
Member

Thanks @lrjball

In test_column_transformer_dataframe(), X_df2 was created but never used. X_df was mistakely being used in its place. The PR fixes that typo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0