8000 [MRG] minor fix in gaussian_mixture.py by djsutherland · Pull Request #14120 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] minor fix in gaussian_mixture.py #14120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2019
Merged

[MRG] minor fix in gaussian_mixture.py #14120

merged 1 commit into from
Jun 19, 2019

Conversation

djsutherland
Copy link
Contributor

This was working, since 'full' in 'full', but for clarity and accident-avoidance it's probably better to use ==.

@djsutherland
minor fix in gaussian_mixture.py
8b2fc86 
This was working, since `'full' in 'full'`, but for clarity and accident-avoidance it's probably better to use `==`.
@jnothman
Copy link
Member

Thanks

@jnothman jnothman merged commit b3030f0 into scikit-learn:master Jun 19, 2019
@jnothman
Copy link
Member

Thanks @dougalsutherland

koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@djsutherland @koenvandevelde
minor fix in gaussian_mixture.py (scikit-learn#14120)
5fc1030 
This was working, since `'full' in 'full'`, but for clarity and accident-avoidance it's probably better to use `==`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djsutherland @jnothman
0