8000 MNT fix suppressing matplotlib warning issue while making docs by adrinjalali · Pull Request #14115 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MNT fix suppressing matplotlib warning issue while making docs #14115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2019
Merged

MNT fix suppressing matplotlib warning issue while making docs #14115

merged 1 commit into from
Jun 19, 2019

Conversation

adrinjalali
Copy link
Member

For some reason now the UserWarning which we were ignoring, is not under the matplotlib module and the warnings were shown again, hence removing the line from the config to still suppress it.

@adrinjalali adrinjalali requested a review from thomasjpfan June 19, 2019 17:28
@thomasjpfan
Copy link
Member

Can you provide a link to a circleci doc build that has this warning? I am not able to see it locally or in the ci. What matplotlib version are you using?

@adrinjalali
Copy link
Member Author

My matplotlib is 3.1.0, I saw the warnings locally, haven't checked the CI logs.

thomasjpfan
thomasjpfan approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I see the warning now. I am okay with this since the message is a very specific regex, thus it will not filter out other warnings from other libraries.

rth
rth approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rth rth merged commit 801cca8 into scikit-learn:master Jun 19, 2019
@adrinjalali adrinjalali deleted the doc/matplotlib-8473 branch June 19, 2019 20:41
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@adrinjalali @koenvandevelde
MNT fix suppressing matplotlib warning issue while making docs (sciki…
0548d06 
…t-learn#14115)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrinjalali @thomasjpfan @rth
0