8000 PERF Don't allocate space for bias element if there isn't one by alexhenrie · Pull Request #14108 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

PERF Don't allocate space for bias element if there isn't one #14108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2019
Merged

PERF Don't allocate space for bias element if there isn't one #14108

merged 1 commit into from
Jun 18, 2019

Conversation

alexhenrie
Copy link
Contributor

When doing regression with 65 million samples and no bias, this patch saves 780 megabytes of memory.

jnothman
jnothman approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member
@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jnothman
Copy link
Member

Please add an entry to the change log at doc/whats_new/v0.22.rst. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:

@alexhenrie
Copy link
Contributor Author

@jnothman OK I added a brief note and amended the commit. What do you think?

rth
rth reviewed Jun 18, 2019
View reviewed changes
@rth
Copy link
Member
rth commented Jun 18, 2019

I added a brief note and amended the commit.

A minor point just FYI (for the future) better not to amend commits in a PR but add new ones. We squash PRs anyway in the end, and separate commits make it easier to review what changed since the last review. Here the diff is short enough that it's fine in any case.

rth
rth approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rth rth merged commit 7ce8b21 into scikit-learn:master Jun 18, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@alexhenrie @koenvandevelde
PERF Don't allocate space for bias element if there isn't one (scikit…
fa17b28 
…-learn#14108)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexhenrie @jnothman @rth
0