8000 MAINT Remove sudo tag in travis by abhinavsagar · Pull Request #14050 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Remove sudo tag in travis #14050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2019
Merged

MAINT Remove sudo tag in travis #14050

merged 2 commits into from
Jun 13, 2019

Conversation

abhinavsagar
Copy link
Contributor

Travis are now recommending removing the sudo tag.
Check out this.

@thomasjpfan
Copy link
Member

Please trigger the travis ci with the following to see if the configuration works:

git commit --allow-empty -m "BLD Trigger CI [scipy-dev]"

@abhinavsagar
Copy link
Contributor Author

@thomasjpfan Yes this is working.

@thomasjpfan
Copy link
Member
thomasjpfan commented Jun 9, 2019 •
edited
Loading

May you include a link to a travis ci instance that ran the tests with this change, so we can confirm that it works?

@abhinavsagar
Copy link
Contributor Author

On running the git commit --allow-empty -m "BLD Trigger CI [scipy-dev]" command locally, I am getting
[fix-typos 88ae3ad1e] BLD Trigger CI [scipy-dev]. So hope it's working.

@thomasjpfan
Copy link
Member

Did you push it to github?

@abhinavsagar
Copy link
Contributor Author

Yes, I pushed the changes. If you are a member, you can test it right ?

@thomasjpfan
Copy link
Member
thomasjpfan commented Jun 9, 2019 •
edited
Loading

Your branch name on github is called patch-1, your comment suggest that your local branch is called fix-types. Did you push to patch-1?

(Edit: We do not know if we need to make more changes to travis scripts when sudo is removed. I haven't tested if [scipy-dev] still works for trigger travis on PRs.)

@abhinavsagar
Copy link
Contributor Author

Yes, I have pushed to patch-1

@thomasjpfan
Copy link
Member
thomasjpfan commented Jun 9, 2019 •
edited
Loading

The BLD Trigger commit is not shown in your patch-1 branch: https://github.com/abhinavsagar/scikit-learn/commits/patch-1

@abhinavsagar
Copy link
Contributor Author

Sorry, but I don't have any idea. On testing it locally, it is working fine.

@rth
Copy link
Member
rth 8000 commented Jun 11, 2019

On testing it locally, it is working fine.

@abhinavsagar You cannot check locally that Travis CI is working. It's a cloud service that will only run if you add a commit to this PR with the above-mentionned commit message. So you need to checkout the patch-1 branch locally, add that commit and push.

jnothman
jnothman approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member
@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem to be working in travis.

@jnothman jnothman changed the title Remove sudo tag in travis MAINT Remove sudo tag in travis Jun 13, 2019
@rth rth merged commit 50425e1 into scikit-learn:master Jun 13, 2019
@abhinavsagar abhinavsagar deleted the patch-1 branch June 13, 2019 09:49
koenvandevelde pushed a commit to koenvandevelde/scikit-learn th 7FFA at referenced this pull request Jul 12, 2019
@abhinavsagar @koenvandevelde
MAINT Remove sudo tag in travis (scikit-learn#14050)
32617ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhinavsagar @thomasjpfan @rth @jnothman
0