DOC Improve OPTICS doc #13866
Merged
DOC Improve OPTICS doc #13866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
approved these changes
May 14, 2019
| X : array, shape (n_samples, n_features) | ||
| The data. | ||
| X : array, shape (n_samples, n_features), or (n_samples, n_samples) \ | ||
| if metric=’precomputed’. |
There was a problem hiding this comment.
I prefer this indented... I don't see any reason to have it flush left.
Suggested change
| if metric=’precomputed’. | |
| if metric=’precomputed’. |
There was a problem hiding this comment.
See #5078, we do similar things in some latest classes, e.g., ColumnTransformer
There was a problem hiding this comment.
If I had time to pull this into an ancient discussion of this at numpydoc, I would... Thanks
| X : array, shape (n_samples, n_features) | ||
| The data. | ||
| X : array, shape (n_samples, n_features), or (n_samples, n_samples) \ | ||
| if metric=’precomputed’. |
There was a problem hiding this comment.
Suggested change
| if metric=’precomputed’. | |
| if metric=’precomputed’. |
Co-Authored-By: Joel Nothman <joel.nothman@gmail.com>
jnothman
approved these changes
May 15, 2019
|
Thanks |
jnothman
pushed a commit
that referenced
this pull request
May 15, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) More notes about the difference between our implementation and the original paper
(2) We support metric='precomputed' (tested in test_precomputed_dists)
(3) Update the description of max_eps to keep consistent with DBSCAN (see #13563)
ping @jnothman @adrinjalali