-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
[MRG+1] add example to IsotonicRegression class #13768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sklearn/isotonic.py
Outdated
@@ -209,7 +209,18 @@ class IsotonicRegression(BaseEstimator, TransformerMixin, RegressorMixin): | |||
|
|||
Correctness of Kruskal's algorithms for monotone regression with ties | |||
Leeuw, Psychometrica, 1977 | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove one of these empty lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @veerlosar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would predicting a couple more points make it clearer that the model is isotonic?
I could add some more points, but I tried and it doesn't show on a really small datasets like this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks
Towards #3846
this PR adds an example to IsotonicRegression class
ping @adrinjalali