8000 [MRG+1] add example to IsotonicRegression class by veerlosar · Pull Request #13768 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG+1] add example to IsotonicRegression class #13768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 4, 2019
Merged

[MRG+1] add example to IsotonicRegression class #13768

merged 3 commits into from
May 4, 2019

Conversation

veerlosar
Copy link
Contributor

Towards #3846

this PR adds an example to IsotonicRegression class

ping @adrinjalali

adrinjalali
adrinjalali reviewed May 2, 2019
View reviewed changes
sklearn/isotonic.py Outdated
@@ -209,7 +209,18 @@ class IsotonicRegression(BaseEstimator, TransformerMixin, RegressorMixin):

Correctness of Kruskal's algorithms for monotone regression with ties
Leeuw, Psychometrica, 1977


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove one of these empty lines

adrinjalali
adrinjalali approved these changes May 2, 2019
View reviewed changes
Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @veerlosar

@adrinjalali adrinjalali changed the title add example to IsotonicRegression class [MRG+1] add example to IsotonicRegression class May 2, 2019
jnothman
jnothman reviewed May 3, 2019
View reviewed changes
Copy link
Member
@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would predicting a couple more points make it clearer that the model is isotonic?

@veerlosar
Copy link
Contributor Author

Would predicting a couple more points make it clearer that the model is isotonic?

I could add some more points, but I tried and it doesn't show on a really small datasets like this one

jnothman
jnothman approved these changes May 4, 2019
View reviewed changes
Copy link
Member
@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks

@jnothman jnothman merged commit 28728f5 into scikit-learn:master May 4, 2019
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request May 6, 2019
@veerlosar @jnothman
DOC add example to IsotonicRegression class (scikit-learn#13768)
2f2523b
@veerlosar veerlosar deleted the example/isotonic branch May 14, 2019 18:14
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@veerlosar @koenvandevelde
DOC add example to IsotonicRegression class (scikit-learn#13768)
f67b1d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veerlosar @jnothman @adrinjalali
0