8000 TST use approximate equality for float comparison in cross_val_predict tests by jnothman · Pull Request #13749 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST use approximate equality for float comparison in cross_val_predict tests #13749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2019
Merged

TST use approximate equality for float comparison in cross_val_predict tests #13749

merged 1 commit into from
Apr 30, 2019

Conversation

jnothman
Copy link
Member

No description provided.

@jnothman jnothman added this to the 0.21 milestone Apr 30, 2019
@jnothman jnothman mentioned this pull request Apr 30, 2019
Merged
@jnothman
Copy link
Member Author

This fixes the issue. Compare https://travis-ci.org/MacPython/scikit-learn-wheels/jobs/526407978 and https://travis-ci.org/MacPython/scikit-learn-wheels/jobs/526392063.

Approve it?

@jnothman
Copy link
Member Author

I'm sure this is uncontroversial. I'll merge.

@jnothman jnothman merged commit cc0179a into scikit-learn:master Apr 30, 2019
jnothman added a commit that referenced this pull request Apr 30, 2019
@jnothman
TST use approximate equality for float comparison (#13749)
60eb00c
@ogrisel
Copy link
Member
ogrisel commented Apr 30, 2019

+1 (too late :)

marcelobeckmann pushed a commit to marcelobeckmann/scikit-learn that referenced this pull request May 1, 2019
@jnothman @marcelobeckmann
TST use approximate equality for float comparison (scikit-learn#13749)
84dfcf1
marcelobeckmann pushed a commit to marcelobeckmann/scikit-learn that referenced this pull request May 1, 2019
@jnothman @marcelobeckmann
TST use approximate equality for float comparison (scikit-learn#13749)
f40273f
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@jnothman @koenvandevelde
TST use approximate equality for float comparison (scikit-learn#13749)
6dd4722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
0.21
Development

Successfully merging this pull request may close these issues.
3 participants
@jnothman @ogrisel @qinhanmin2014
0