8000 [MRG] Added additional tips for pytest usage by NicolasHug · Pull Request #13540 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] Added additional tips for pytest usage #13540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2019
Merged

[MRG] Added additional tips for pytest usage #13540

merged 3 commits into from
Mar 28, 2019

Conversation

NicolasHug
Copy link
Member

This PR:

  • Adds a link from the testing section contributing.rst to the pytest tips and tricks.
  • Mentions a few useful command options that I personally use all the time (I won't push them though, if you don't think they're appropriate): -x, --lf, -s, tb=short
  • Recommends using the -Werror::DeprecationWarning and -Werror::FutureWarning flags. This isn't mentioned anywhere as far as I know and it is often a source of confusion for new contributors. See e.g. Add an easy way to run pytest -Werror::DeprecationWarning -Werror::FutureWarning #13396

rth
rth approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NicolasHug !

I also use these frequently and it's true that they are not much documented in the contribution guide.

@adrinjalali
Copy link
Member

good one!

@adrinjalali adrinjalali merged commit 5b747cf into scikit-learn:master Mar 28, 2019
@agramfort
Copy link
Member

I don't know if we mention it but pytest-sugar is also a must have.

xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
@NicolasHug
DOC Added additional tips for pytest usage (scikit-learn#13540)
0a5e164 
* Added additional tips for pytest

* Added --ff option

* typo
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "DOC Added additional tips for pytest usage (scikit-learn#13540)"
c44b4c6 
This reverts commit 0a5e164.
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "DOC Added additional tips for pytest usage (scikit-learn#13540)"
2c6e490 
This reverts commit 0a5e164.
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@NicolasHug @koenvandevelde
DOC Added additional tips for pytest usage (scikit-learn#13540) 77CD
6f7d8f3 
* Added additional tips for pytest

* Added --ff option

* typo
@cmarmo cmarmo mentioned this pull request Apr 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NicolasHug @adrinjalali @agramfort @rth
0