8000 Pandas DataFrame Categories supported by OneHotEncoder by maikia · Pull Request #13351 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Pandas DataFrame Categories supported by OneHotEncoder #13351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Pandas DataFrame Categories supported by OneHotEncoder #13351

wants to merge 3 commits into from

Conversation

maikia
Copy link
Contributor
@maikia maikia commented Mar 1, 2019 •
edited by jorisvandenbossche
Loading

If one of the features is Pandas Categorical it is supported by OneHotEncoder and the categories will be kept as set

TODO:

  • Validate the dtype between fit and transform (for now only allow exactly the same dtype)
  • Deprecation path:
    • By default still do it the old way, but provide a way to opt in to the new behaviour
  • Test that the order of the categories is used

maikia added 2 commits March 1, 2019 16:40
@maikia
check if the dtype is the same of the features passed to fit and to t…
74d72bb 
…ransform. In case of categorical check if corresponding categories are the same
@maikia
removed checking if the dtype is the same iin fit and transform (from…
07256d2 
… previous commit), only checking categories remains
@amueller
Copy link
Member
amueller commented Aug 6, 2019

Are you still working on this? Related to #12086 and #12147 and #13253

@jnothman jnothman mentioned this pull request Oct 27, 2019
Open
This was referenced Oct 28, 2019
Open
Closed
Base automatically changed from master to main January 22, 2021 10:50
@glemaitre
Copy link
Member

@maikia I'm closing this PR since the code of the encoders changed quite a lot. We will still consider the issue and come if a better handling of the CategoricalDType

@glemaitre glemaitre closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:preprocessing Needs work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maikia @amueller @glemaitre
0