[MRG] CLN: remove duplicate validation of X in Encoders transform #13347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
approved these changes
Mar 1, 2019
GaelVaroquaux
approved these changes
Mar 1, 2019
| X = X_temp | ||
|
|
||
| n_samples, n_features = X.shape | ||
|
|
There was a problem hiding this comment.
Maybe it would be useful to add a comment saying that input validation is done in self._transform
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…cikit-learn#13347)" This reverts commit d450524.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…cikit-learn#13347)" This reverts commit d450524.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
self._transformmethod already callsself._check_Xwhich does this same validation (check_array) of X, so it should not be needed here (and confirmed by by the passing tests).This also prevented actually handling the DataFrame column by column on transform (#13253), but this is difficult to test now since both numpy and python encoding methods result in the same.