8000 TST remove _UnstableOn32BitMixin from kpca class by agramfort · Pull Request #13284 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST remove _UnstableOn32BitMixin from kpca class #13284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2019
Merged

TST remove _UnstableOn32BitMixin from kpca class #13284

merged 1 commit into from
Feb 27, 2019

Conversation

agramfort
Copy link
Member

see after #13241 if we can remove _UnstableOn32BitMixin

cc @rth

@ogrisel
Copy link
Member
ogrisel commented Feb 26, 2019

We probably need to add 32 bit Python on windows and probably one 32bit linux (e.g. in a docker container such as the manylinux ones for the i686 platform) on azure pipelines to properly test this PR. Otherwise we might have bad surprise a release time.

@ogrisel
Copy link
Member
ogrisel commented Feb 26, 2019

Actually we could also monitor the MacPython/scikit-learn-wheels cron jobs once this PR is merged (if appveyor is ok).

@ogrisel
Copy link
Member
ogrisel commented Feb 26, 2019

I forgot to ping @thomasjpfan in the previous comments.

@ogrisel
Copy link
Member
ogrisel commented Feb 26, 2019

The AppVeyor queue is clogged right now, so we will have to wait a bit :)

ogrisel
ogrisel approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have enabled the 32 bit linux nightly builds on MacPython/scikit-learn-wheels:

MacPython/scikit-learn-wheels@2ec0a25

So +1 for merging this and we will see soon if it breaks 32 bit linux or not. If it does it's easy enough to readd the _UnstableOn32bitMixin.

rth
rth approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's merge and see.

@rth rth changed the title [WIP] remove _UnstableOn32BitMixin from kpca class remove _UnstableOn32BitMixin from kpca class Feb 27, 2019
@rth rth merged commit b65afbf into scikit-learn:master Feb 27, 2019
@rth rth changed the title remove _UnstableOn32BitMixin from kpca class TST remove _UnstableOn32BitMixin from kpca class Feb 27, 2019
@thomasjpfan thomasjpfan mentioned this pull request Feb 27, 2019
Merged
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
@agramfort
TST remove _UnstableOn32BitMixin from kpca class (scikit-learn#13284)
cc8b6db
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "TST remove _UnstableOn32BitMixin from kpca class (scikit-lear…
0258ded 
…n#13284)"

This reverts commit cc8b6db.
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "TST remove _UnstableOn32BitMixin from kpca class (scikit-lear…
237f4fd 
…n#13284)"

This reverts commit cc8b6db.
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@agramfort @koenvandevelde
TST remove _UnstableOn32BitMixin from kpca class (scikit-learn#13284)
fe08646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agramfort @ogrisel @rth
0