8000 [MRG] avoid storage of each tree predictions in iforest by ngoix · Pull Request #13260 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] avoid storage of each tree predictions in iforest #13260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2019
Merged

[MRG] avoid storage of each tree predictions in iforest #13260

merged 1 commit into from
Mar 2, 2019

Conversation

ngoix
Copy link
Contributor
@ngoix ngoix commented Feb 25, 2019

fixes (partly) #12040

will do the chunking of X_test in another PR for clarity

@ngoix
Copy link
Contributor Author
ngoix commented Feb 25, 2019

should not be too hard to rebase on #13251

@ngoix ngoix changed the title [WIP] avoid storage of each tree predictions [MRG] avoid storage of each tree predictions Feb 26, 2019
@ngoix ngoix changed the title [MRG] avoid storage of each tree predictions [MRG] avoid storage of each tree predictions in iforest Feb 26, 2019
@glemaitre
Copy link
Member

It seems that you are modifying something which is changed in #13251 as well.
@albertcthomas it seems that we should kill one of the 2 PRs isn't it?

glemaitre
glemaitre reviewed Feb 26, 2019
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I see that we could use the common tests from @albertcthomas

@ngoix
Copy link
Contributor Author
ngoix commented Feb 26, 2019

I don't think so, #13251 has nothing to do with the changes here. Conflicts will be on the changes in value of _average_path_length(1) and _average_path_length(2) so shouldn't be a problem. Let's merge #13251 first.

@albertcthomas
Copy link
Contributor

I think @ngoix is right, #13251 only changes a few output values of _average_path_length.

@ngoix ngoix mentioned this pull request Feb 26, 2019
Merged
@albertcthomas
Copy link
Contributor

#13251 has just been merged so you can rebase @ngoix.

@jnothman jnothman mentioned this pull request Feb 27, 2019
Closed
jnothman
jnothman reviewed Feb 28, 2019
View reviewed changes
albertcthomas
albertcthomas approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor
@albertcthomas albertcthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agramfort
Copy link
Member

@ngoix please update what's new 0.21.rst

and +1 for MRG. thanks

@banilo
Copy link
Contributor
banilo commented Mar 1, 2019

looks good

< 8000 div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDQ2ODkyNjA1Mw==">
@ngoix
Copy link
Contributor Author
ngoix commented Mar 2, 2019

@agramfort can you merge?

adrinjalali
adrinjalali approved these changes Mar 2, 2019
View reviewed changes
Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adrinjalali adrinjalali merged commit 12705bb into scikit-learn:master Mar 2, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
@ngoix
ENH avoid storage of each tree predictions (scikit-learn#13260)
a105000
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "ENH avoid storage of each tree predictions (scikit-learn#13260)"
17e3a21 
This reverts commit a105000.
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "ENH avoid storage of each tree predictions (scikit-learn#13260)"
ed7f031 
This reverts commit a105000.
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@ngoix @koenvandevelde
ENH avoid storage of each tree predictions (scikit-learn#13260)
c998491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre left review comments

@jnothman jnothman jnothman approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

@albertcthomas albertcthomas albertcthomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ngoix @glemaitre @albertcthomas @agramfort @banilo @jnothman @adrinjalali
0