-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
[MRG] Unary encoder -- continued #12893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
NicolasHug
wants to merge
37
commits into
scikit-learn:master
from
NicolasHug:unary_encoder_continued
Closed
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
38537ed
Rebase and commit the OrdinalEncoder implementation
arjunjauhari a850082
Updating name to UnaryEncoder and adding single quote in error string
arjunjauhari 661951c
Merged changes from #9216
ruxandraburtica eb8bc94
Removing active_features_ attribute from UnaryEncoder as it is not ne…
arjunjauhari 88d5eb4
Limiting the lines in documentation to less that 80 chars
arjunjauhari cd21cbf
Updated documentation. Changed the default value of sparse parameter …
arjunjauhari 81af018
Updated test cases to accomodate change in default value of sparse pa…
arjunjauhari f4ba310
Commit to accomodate all the requested changes
arjunjauhari 0706c29
Fixing DocTestFailure
arjunjauhari b642a7e
Refactoring the code. Now fit_transform in equivalent to fit +
arjunjauhari 367dba4
Minor change in mask calculation.
arjunjauhari 9f3205d
Adding warn as a new option for handle_greater parameter.
arjunjauhari c23ec8d
Updating test case to take care of new handle_greater='warn' as default
arjunjauhari 9d4753a
Fixing concerns.
arjunjauhari a43dfb5
Resolved conflicts with master
arjunjauhari 7cbf733
8000
Merge branch 'master' into unary_encoder_continued
NicolasHug e2a01bb
some doc modif, TBC
NicolasHug fc6a9af
removed ordinal_features
NicolasHug 645f6a3
Removed calls to _transform_selected
NicolasHug 4691026
Addressed Joris' comments
NicolasHug 35cbbe4
Added inverse tranform
NicolasHug b4609fe
Updated user guide
NicolasHug 98c0e5a
Added whatsnew
NicolasHug 7886fb7
Removed from __all__ in preprocesing.data
NicolasHug e96b438
Fixed typo
NicolasHug 4d690e9
Added @ruxandraburtica as author
NicolasHug 6d4cb04
renamed n_values into categories
NicolasHug d5ec004
Added example for combining with OrdinalEncoder in user guide
NicolasHug b56ef10
Merge branch 'master' into unary_encoder_continued
NicolasHug e1f2f3f
Removed six usage
NicolasHug 54861d2
Addressed most comments from Joel
NicolasHug 192e042
typos
NicolasHug 57538f0
inverse transform now accepts non-binary input
NicolasHug 7af673b
newline EOF
NicolasHug e2c90dd
Added section in OrdinalEncoder user guide for specifying categories
NicolasHug 5d69bf9
changed categories param to max_value
NicolasHug 5350ba8
Addressed comments
NicolasHug File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about how to motivate this encoder properly. Please feel free to suggest anything better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like "if the difference between ordered categories is uneven".
How about
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe an example of an ordinal variable would then be helpful