8000 [MRG] DOC add sentence about line length of rst files by albertcthomas · Pull Request #12883 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] DOC add sentence about line length of rst files #12883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2018
Merged

[MRG] DOC add sentence about line length of rst files #12883

merged 1 commit into from
Dec 28, 2018

Conversation

albertcthomas
Copy link
Contributor

Reference Issues/PRs

Fixes #12871

What does this implement/fix? Explain your changes.

This adds a sentence in the Guidelines for writing documentation saying to keep line length of rst files under 80 characters when possible.

qinhanmin2014
qinhanmin2014 approved these changes Dec 28, 2018
View reviewed changes
Copy link
Member
@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be conservative and wait for a +2 here.

rth
rth approved these changes Dec 28, 2018
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @albertcthomas !

@rth rth merged commit d6095eb into scikit-learn:master Dec 28, 2018
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Jan 7, 2019
@albertcthomas @adrinjalali
DOC add sentence about line length of rst files (scikit-learn#12883)
22956f8
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Feb 19, 2019
@albertcthomas @jnothman
DOC add sentence about line length of rst files (scikit-learn#12883)
3a60270
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
@albertcthomas
DOC add sentence about line length of rst files (scikit-learn#12883)
41a971b
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "DOC add sentence about line length of rst files (scikit-learn…
3bdead7 
…#12883)"

This reverts commit 41a971b.
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "DOC add sentence about line length of rst files (scikit-learn…
d1f297d 
…#12883)"

This reverts commit 41a971b.
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@albertcthomas @koenvandevelde
DOC add sentence about line length of rst files (scikit-learn#12883)
ec6f84d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOC: line length of rst files should be kept lower than 80 characters
3 participants
@albertcthomas @rth @qinhanmin2014
0