Copy _make_estimator parameters #12690
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
reviewed
Jul 13, 2019
| @@ -124,7 +125,7 @@ def _make_estimator(self, append=True, random_state=None): | |||
| sub-estimators. | |||
| """ | |||
| estimator = clone(self.base_estimator_) | |||
| estimator.set_params(**dict((p, getattr(self, p)) | |||
| estimator.set_params(**dict((p, copy.deepcopy(getattr(self, p))) | |||
There was a problem hiding this comment.
would it make sense rather copy the parameters in the set_params
|
Well you can add a smoke test and if it segfaults we know that we messed up, right? |
|
@wyegelwel do you intend to complete this? |
|
I'm running into the same issue and confirmed that the patch fixes it. What is left to get this over the line? Does it just need a smoke test? @amueller |
|
@aadamson yes, it seems it needs a smoke test and a contributor. You're welcome to take it on |
|
Great, thanks. I'll take a look this week. |
|
@cstefansen I had a branch that I never pushed with a smoke test that should cover this. See #18985. |
|
Closing as resolved in #19580 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #12623
What does this implement/fix? Explain your changes.
The issue is that when trees are created by the base ensemble class, the parameters are not copied. This is problematic in the case of the criterion parameter if a Criterion object is passed in. When this happens, all the trees share the same object and mutate it. If n_jobs > 1, they are mutating the same object concurrently.
Any other comments?
I couldn't think of a good test for this fix. Since the repro case causes a segfault it is hard to add a test case that doesn't cause grief.