DOC removed ambiguity in pipeline gridsearch example #12272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
Oct 4, 2018
There was a problem hiding this comment.
Thanks. I think this is legacy code from before None was supported. Soon this should probably be replaced with passthrough (#11674, ping @thomasjpfan)
jnothman
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
In the example the dimension reduction method is replaced by the values from the parameter grid. It is confusing to declare it as PCA(), only for this to be ignored. Replacing it with None indicates to the reader that this is blank or a placeholder.
Note: This confusion is not my own. It comes from my students who were confused when reading the example during a tutorial.