Fixing summary table in the linear model documentation. #12220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool let's wait for circle to build the docs so we can check how it looks! |
qinhanmin2014
approved these changes
Sep 30, 2018
| In a nutshell, the following table summarizes the penalties supported by each solver: | ||
|
|
||
| +------------------------------+-----------------+-------------+-----------------+-----------+------------+ | ||
| | | **Solvers** | |
There was a problem hiding this comment.
solvers won't be in the middle, but I won't be too strict here.
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I corrected the formatting of the table summarizing logistic regression "solver" behaviors and penalties in the linear model documentation.
Reference Issues/PRs
The formatting error was suggested in the following document: https://docs.google.com/document/d/1dgEPcGnbfs6DRs7qtZMkbF6mLP6cywfn46rMFGRmTQg/edit
What does this implement/fix? Explain your changes.
I updated the table formatting to allow two table sections, one for penalties and one for behaviors.