[MRG] Remove duplicate import of warnings & unused variables #12203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amueller
reviewed
Sep 29, 2018
sklearn/ensemble/forest.py
Outdated
| @@ -41,7 +41,8 @@ class calls the ``fit`` method of each sub-estimator on random samples | |||
|
|
|||
| from __future__ import division | |||
|
|
|||
| import warnings | |||
| from warnings import catch_warnings | |||
There was a problem hiding this comment.
You can do multiple imports on the same line, from warnings import catch_warnings, simplefilter, warn
amueller
reviewed
Sep 29, 2018
amueller
reviewed
Sep 29, 2018
| @@ -217,7 +216,7 @@ def fit(self, X, y=None, sample_weight=None): | |||
| self._contamination = self.contamination | |||
|
|
|||
| if self.behaviour == 'old': | |||
| warnings.warn('behaviour="old" is deprecated and will be removed ' | |||
| warn('behaviour="old" is deprecated and will be removed ' | |||
There was a problem hiding this comment.
actually I think you need to fix the indentation here. make sure you run flake8 on this file
|
This pull request fixes 4 alerts when merging dcb585d into 2cf145d - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
|
This pull request fixes 4 alerts when merging db45167 into 2cf145d - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
amueller
approved these changes
Sep 29, 2018
qinhanmin2014
approved these changes
Sep 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #12167
This resolves several LGTM alerts in /ensemble: