DOC More specific about the limitation of make_column_transformer #12163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
Sep 26, 2018
| @@ -691,7 +691,7 @@ def make_column_transformer(*transformers, **kwargs): | |||
| This is a shorthand for the ColumnTransformer constructor; it does not | |||
| require, and does not permit, naming the transformers. Instead, they will | |||
| be given names automatically based on their types. It also does not allow | |||
| weighting. | |||
| weighting, i.e., it does not accept parameter ``transformer_weights``. | |||
There was a problem hiding this comment.
I think more helpful would be a comment in the file for maintainers on why it cannot accept transformer_weights :)
|
Oh, I see that's what was in the previous PR. Let's just make this more succinct "does not allow weighting with |
Yes, the previous PR is for developers and this one is for users. |
jnothman
approved these changes
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #12156. I guess we might want some clarification in the doc.