8000 MAINT Fix invalid escape sequence (#12058 cntd.) by adrinjalali · Pull Request #12064 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Fix invalid escape sequence (#12058 cntd.) #12064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2018
Merged

MAINT Fix invalid escape sequence (#12058 cntd.) #12064

merged 3 commits into from
Sep 13, 2018

Conversation

adrinjalali
Copy link
Member

Continuing #12058

qinhanmin2014
qinhanmin2014 approved these changes Sep 13, 2018
View reviewed changes
Copy link
Member
@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @adrinjalali Will merge when green.
I'm afraid we have to modify _arff.py here. We should submit a PR to the upstream project.

@qinhanmin2014 qinhanmin2014 merged commit 36536c6 into scikit-learn:master Sep 13, 2018
@qinhanmin2014 qinhanmin2014 mentioned this pull request Sep 13, 2018
Closed
@adrinjalali adrinjalali mentioned this pull request Sep 13, 2018
Merged
@adrinjalali adrinjalali deleted the escape branch September 13, 2018 09:24
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Sep 17, 2018
@adrinjalali @jnothman
MAINT Fix invalid escape sequence (scikit-learn#12064)
09b8434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrinjalali @jnothman @qinhanmin2014
0