8000 MNT Revert the deprecation of min_samples_leaf and min_weight_fraction_leaf by jnothman · Pull Request #11998 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MNT Revert the deprecation of min_samples_leaf and min_weight_fraction_leaf #11998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2018
Merged

MNT Revert the deprecation of min_samples_leaf and min_weight_fraction_leaf #11998

merged 2 commits into from
Sep 8, 2018

Conversation

jnothman
Copy link
Member
@jnothman jnothman commented Sep 4, 2018

And improve the documentation of min_samples_leaf.

Fixes #11976

What do others think?

amueller
amueller approved these changes Sep 7, 2018
View reviewed changes
Copy link
Member
@amueller amueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Sorry for pushing for this, clearly not thinking about all cases.

@amueller
Copy link
Member
amueller commented Sep 7, 2018

can we tag blockers for the final release?

@jnothman jnothman added this to the 0.20 milestone Sep 8, 2018
rth
rth approved these changes Sep 8, 2018
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rth rth merged commit 79f5d14 into scikit-learn:master Sep 8, 2018
jnothman added a commit to jnothman/scikit-learn that referenced this pull request Sep 9, 2018
@jnothman
MNT Revert the deprecation of min_samples_leaf and min_weight_fractio…
f5b426a 
…n_leaf (scikit-learn#11998)
jnothman added a commit to jnothman/scikit-learn that referenced this pull request Sep 17, 2018
@jnothman
MNT Revert the deprecation of min_samples_leaf and min_weight_fractio…
f47c360 
…n_leaf (scikit-learn#11998)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amueller amueller amueller approved these changes

@rth rth rth approved these changes

Assignees
No one assigned
Labels
Blocker
Projects
None yet
Milestone
0.20
Development

Successfully merging this pull request may close these issues.
3 participants
@jnothman @amueller @rth
0