[MRG] Mimimal refactoring of gradient_boosting.py #11921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
approved these changes
Aug 29, 2018
| @@ -1545,17 +1537,13 @@ def _fit_stages(self, X, y, y_pred, sample_weight, random_state, | |||
| X_csc, X_csr) | |||
|
|
|||
| # track deviance (= loss) | |||
| self.train_score_[i] = loss_(y[sample_mask], y_pred[sample_mask], | |||
There was a problem hiding this comment.
to avoid making a copy of the data, you might use sample_mask = slice(None, None)
There was a problem hiding this comment.
I reverted the changes, thanks for the warning. Using slice would break at some other places.
|
Thanks |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Aug 30, 2018
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Some minimal changes to gradient_boosting.py to make code shorter and IMHO slightly easier to follow.
Any other comments?