8000 [MRG] Added 'l2' as acceptable input for loss in l1_min_c() by maxcopeland · Pull Request #11871 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] Added 'l2' as acceptable input for loss in l1_min_c() #11871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2018
Merged

[MRG] Added 'l2' as acceptable input for loss in l1_min_c() #11871

merged 2 commits into from
Aug 21, 2018

Conversation

maxcopeland
Copy link
Contributor

Fixes #11851

Currently, passing "l2" to loss parameter raises ValueError in l1_min_c().
Added "l2" as acceptable input for loss.

@agramfort
Copy link
Member

are you reverting this commit

scikit-learn/sklearn/svm/bounds.py

Line 55 in f6fd03e

raise ValueError('loss type not in ("squared_hinge", "log", "l2")')
?

@amueller
Copy link
Member

I think the desired fix would have been to remove it from the error message.

@maxcopeland
removed "l2" from error msg in l1_min_c()
89c99c3 
removed `"l2"` from error msg in l1_min_c(), consistent with acceptable `loss` params
@maxcopeland
Copy link
Contributor Author

Ah, I see-- that also explains why the build failed. Sorry about that. I removed "l2" from error message.

@amueller
Copy link
Member

thanks

@amueller amueller merged commit c11206d into scikit-learn:master Aug 21, 2018
@maxcopeland maxcopeland deleted the add_l2loss_to_bounds branch August 21, 2018 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxcopeland @agramfort @amueller
0