FIX towards disregarding multi_class in the case of binary y #11859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amueller
reviewed
Aug 20, 2018
| multi_class = 'ovr' | ||
| # np.unique(y) gives labels in sorted order. | ||
| pos_class = classes[1] | ||
| if pos_class is None: |
Member
There was a problem hiding this comment.
Took the liberty to push this if, which I thought was missing. Still some other issues with the coef_ shape.
This was referenced Aug 20, 2018
Member
Author
|
Sorry, I'd completed the fix, but fell asleep. |
Member
Author
|
Closing in preference for #11868 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not quite ready. Apparently just changing
:to...wasn't the quick fix I needed.