8000 [MRG+1] FIX hotfix for joblib#741 by jnothman · Pull Request #11837 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG+1] FIX hotfix for joblib#741 #11837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2018
Merged

[MRG+1] FIX hotfix for joblib#741 #11837

merged 2 commits into from
Aug 20, 2018

Conversation

jnothman
Copy link
Member

I'm getting impatient for the 0.20 release, admittedly.

This is so we can get the dev docs compiling online, so that we can announce an RC that includes joblib 0.12/loky (not that we get much feedback from an RC).

Is a hotfix acceptable here, assuming that Joblib will be fixed before final release?

@jnothman jnothman mentioned this pull request Aug 16, 2018
Merged
@qinhanmin2014
Copy link
Member

[doc build], maybe?

@rth
Copy link
Member
rth commented Aug 18, 2018 •
edited
Loading

Travis CI fails due to flake8 timeout (?) , CircleCI fails due to mldata (should be fixed now) and Appveyor 32 fails due to unrelated issue (fixed in #11852)

@rth
Copy link
Member
rth commented Aug 18, 2018 •
edited
Loading

Restarted Circle CI, hopefully it should pass now that #11466 is merged.

Apart for it making CI pass, I don't have a good understanding of the side effects this change may have.

It would have been great to have an option from joblib core devs on this, even if it's a temporary hotfix (cc @lesteve @GaelVaroquaux ) ..

For future reference, PRs aiming to fix this properly are joblib/joblib#743 and joblib/joblib#746

@jnothman
Copy link
Member Author

The aim here would be to be able to declare an RC (we can't do that without live docs), but not release a final version without overwriting this with the official fix.

@qinhanmin2014 qinhanmin2014 added this to the 0.20 milestone Aug 19, 2018
qinhanmin2014
qinhanmin2014 approved these changes Aug 19, 2018
View reviewed changes
Copy link
Member
@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1 to merge this one and release the RC. It seems reasonable and Circle is green.

< 8000 /svg>

@qinhanmin2014 qinhanmin2014 changed the title FIX hotfix for joblib#741 [MRG+1] FIX hotfix for joblib#741 Aug 19, 2018
rth
rth approved these changes Aug 20, 2018
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as the tests and CI goes. Merging.

@rth rth merged commit 774f1aa into scikit-learn:master Aug 20, 2018
@amueller
Copy link
Member

I'm also impatient, I mostly want to resolve the logistic regression thing so we can have the multinomial solver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
Blocker
Projects
None yet
Milestone
0.20
Development

Successfully merging this pull request may close these issues.
4 participants
@jnothman @qinhanmin2014 @rth @amueller
0