8000 [MRG+1] DOC manifold examples added to docstrings by adrinjalali · Pull Request #11823 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

[MRG+1] DOC manifold examples added to docstrings #11823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2018

Conversation

adrinjalali
Copy link
Member

See #3846

Examples added to classes under sklearn/manifold

@adrinjalali adrinjalali changed the title DOC manifold examples added to docstrings [MRG] DOC manifold examples added to docstrings Aug 15, 2018
Copy link
Member
@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we don't need more than this?

@adrinjalali
Copy link
Member Author

What do you mean? You mean more examples? I'm not sure what "this" refers to :P

@adrinjalali adrinjalali changed the title [MRG] DOC manifold examples added to docstrings [MRG+1] DOC manifold examples added to docstrings Aug 15, 2018
@jnothman
Copy link
Member
jnothman commented Aug 15, 2018 via email

@adrinjalali
Copy link
Member Author

Ah yeah, in our department we used it simply as a nice dimensionality reduction technique, with the extra sugar of actually plotting the embedding, then coloring the clusters/classes to somewhat "confirm" the validity of the embedding. Otherwise we used it like these examples.

@qinhanmin2014
Copy link
Member

Is it meaningful to apply manifold learning to Friedman #1 dataset?
Will it be more straightforward to use the digits dataset (or part of it)?

@adrinjalali
Copy link
Member Author

I actually started with the digits dataset, but the tests were too slow. I kinda preferred a generated dataset just to have the sample code cleaner than taking a small [randomly] chosen part of the digits dataset. Also as long as dimensionality reduction goes, I don't see why friedman would be a bad choice.

Still, I can change the examples if you really think it should work on a different dataset.

@qinhanmin2014
Copy link
Member

I actually started with the digits dataset, but the tests were too slow.

Maybe we can use something like X_transformed = embedding.fit_transform(X[:100])

Also as long as dimensionality reduction goes, I don't see why friedman would be a bad choice.

Yes we can reduce the dimension of everything, but according to the definition of friedman, I can't understand what you'll get after dimensionality reduction (and how you benefit from dimensionality reduction).

Copy link
Member
@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @adrinjalali

@qinhanmin2014 qinhanmin2014 merged commit 99a6742 into scikit-learn:master Aug 16, 2018
@adrinjalali adrinjalali deleted the examples/embedding branch August 16, 2018 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0