[MRG] FIX Access Memory's location as a positional arg #11782
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the thing catching CircleCI might be a bug in pickling/unpickling Memory instances in joblib.... raising an issue there |
|
Even if joblib/joblib#741 is fixed, I think this PR improves and the code, reducing deprecation warnings, and should be considered. |
|
Should we wait for joblib/joblib#741 to be merged an another release of joblib made then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why circle was failing claiming that
locationandcachedirwere both set. As far as I can tell, we never set both.However, we can set
cachedirin old versions andlocationin 0.12 by passing them as the first positional argument, rather than a named arg (which is slightly harder to read, but I think that it's still okay). Their semantics are identical as long asbackendis the default.I have also avoided/changed some if-elses currently handling support of multiple joblib versions around this API change.
?Partial fix for #11771