8000 [MRG] ENH Simplify error message of get_scorer by qinhanmin2014 · Pull Request #11738 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

[MRG] ENH Simplify error message of get_scorer #11738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2018
Merged

[MRG] ENH Simplify error message of get_scorer #11738

merged 1 commit into from
Aug 6, 2018

Conversation

qinhanmin2014
Copy link
Member

Closes #11062
Closes #10712
We have more and more scorers, so it seems reasonable to simplify the error message.
What's more, the new error message tells users how to list all the available scorers. (though actually users need to first from sklearn import metrics then sorted(metrics.SCORERS.keys()))

@qinhanmin2014 qinhanmin2014 changed the title ENH Simplify error message of get_scorer [MRG] ENH Simplify error message of get_scorer Aug 3, 2018
@jnothman
Copy link
Member
jnothman commented Aug 5, 2018

@rth, are you happy with this?

Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @qinhanmin2014 ! Merging.

@rth rth merged commit 825cf09 into scikit-learn:master Aug 6, 2018
@qinhanmin2014 qinhanmin2014 deleted the scorer-error-message branch August 7, 2018 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0