8000 [MRG+1] DOC added examples to ridge classes by adrinjalali · Pull Request #11730 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

[MRG+1] DOC added examples to ridge classes #11730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2018

Conversation

adrinjalali
Copy link
Member

See #3846

Added examples to the classes in ridge.py

Copy link
Member
@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @adrinjalali
You don't need [See #3846] in your title :)

>>> from sklearn.datasets import load_diabetes
>>> from sklearn.linear_model import RidgeCV
>>> X, y = load_diabetes(return_X_y=True)
>>> clf = RidgeCV(alphas=[1e-3, 1e-2, 1e-1, 1]).fit(X, y)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to keep consistent within your PR. (either use this one or things like alphas=[1, .01, .001, .0001])

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@qinhanmin2014 qinhanmin2014 changed the title DOC added examples to ridge classes [See #3846] [MRG+1] DOC added examples to ridge classes Aug 2, 2018
@jnothman jnothman merged commit 71ee6d2 into scikit-learn:master Aug 2, 2018
@jnothman
Copy link
Member
jnothman commented Aug 2, 2018

@adrinjalali you are getting quite expert at this game!

@adrinjalali adrinjalali deleted the examples/ridge branch August 2, 2018 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0