[MRG] Fixed bug in _log_reg_scoring_path for multinomial case #11724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
Aug 1, 2018
|
|
||
|
|
||
| def test_log_reg_scoring_path_multinomial(): | ||
| # Make sure that the scores are all different for different C values |
There was a problem hiding this comment.
At the moment you are only checking that some are different. And if so, you only need to test two values of C
Also added entry in whats new and fixed doc
jnothman
approved these changes
Aug 2, 2018
TomDLT
approved these changes
Aug 2, 2018
|
Good catch, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
This PR fixes a weird bug in
logistic_regression_paththat makes_log_reg_scoring_pathgive an incorrect output. Prior to this change, all the scores (from the different C values) would have been the same.Any other comments?
I stumbled upon this while working on #11646.
To be fair I suspect that there are other bugs.
Related but not part of this PR: the doc of
logistic_regression_pathsays that thecoefsattribute is of shape(n_cs, n_features)but that's not true whenmulticlass=multinomial. Should I update the doc? Or is the actual code that is wrong?