8000 [MRG+1] DOC univariate_selection examples in docstrings by adrinjalali · Pull Request #11720 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG+1] DOC univariate_selection examples in docstrings #11720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2018
Merged

[MRG+1] DOC univariate_selection examples in docstrings #11720

merged 2 commits into from
Jul 31, 2018

Conversation

adrinjalali
Copy link
Member

See #3846

Added examples to sklearn/feature_selection/univariate_selection.py classes.

qinhanmin2014
qinhanmin2014 approved these changes Jul 31, 2018
View reviewed changes
Copy link
Member
@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @adrinjalali

sklearn/feature_selection/univariate_selection.py Outdated
>>> X, y = load_breast_cancer(return_X_y=True)
>>> X.shape
(569, 30)
>>> transformer = GenericUnivariateSelect(chi2, 'fpr', param=0.01)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use percentile or k_best here? These might be easier for many users to understand. (optional)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@qinhanmin2014 qinhanmin2014 changed the title univariate_selection examples in docstrings [See #3846] [MRG+1] DOC univariate_selection examples in docstrings Jul 31, 2018
@jnothman jnothman merged commit 360fc07 into scikit-learn:master Jul 31, 2018
@adrinjalali adrinjalali deleted the examples/univariate_selection branch August 1, 2018 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrinjalali @jnothman @qinhanmin2014
0