8000 [MRG+2] change tol in test ridge by sergulaydore · Pull Request #11587 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG+2] change tol in test ridge #11587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2018
Merged

[MRG+2] change tol in test ridge #11587

merged 2 commits into from
Jul 17, 2018

Conversation

sergulaydore
Copy link
Contributor
@sergulaydore sergulaydore commented Jul 17, 2018 •
edited
Loading

Reference Issues/PRs

Fixes #11200 (Instability in test_ridge.py::test_ridge_sample_weights ). The test was failing for some random states. We observed 26 failures for 100 runs.

What does this implement/fix? Explain your changes.

The problem was that the default tolerance in Ridge was 1e-3 and assert_almost_equal uses a tolerance of 1e-6. Adding tol=1e-6 to Ridge fixes the issue.

Any other comments?

The run time takes approximately 1.3 times of previous.
See more details at #11200 (comment)

TomDLT
TomDLT approved these changes Jul 17, 2018
View reviewed changes
Copy link
Member
@TomDLT TomDLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@agramfort agramfort changed the title change tol in test ridge [MRG+2] change tol in test ridge Jul 17, 2018
@GaelVaroquaux
Copy link
Member

Something weird is happening in appveyor. Does someone understand?

I think that I'll still merge.

@GaelVaroquaux
Copy link
Member

OK, merging!

@GaelVaroquaux GaelVaroquaux merged commit a496491 into scikit-learn:master Jul 17, 2018
@sergulaydore sergulaydore deleted the instability_in_test_rigde branch July 18, 2018 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agramfort agramfort agramfort approved these changes

@TomDLT TomDLT TomDLT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instability in test_ridge.py::test_ridge_sample_weights
4 participants
@sergulaydore @GaelVaroquaux @agramfort @TomDLT
0