8000 Replacing log with log1p where applicable. by meetnaren · Pull Request #11428 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Replacing log with log1p where applicable. #11428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 14, 2018
Merged

Replacing log with log1p where applicable. #11428

merged 7 commits into from
Jul 14, 2018

Conversation

meetnaren
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

@meetnaren meetnaren mentioned this pull request Jul 4, 2018
Merged
@qinhanmin2014
Copy link
Member

It seems that the PR is not complete, please carefully follow #11424 (comment).

jnothman
jnothman reviewed Jul 5, 2018
View reviewed changes
Copy link
Member
@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right... I was lax to not check, while on my phone.

qinhanmin2014
qinhanmin2014 approved these changes Jul 14, 2018
View reviewed changes
Copy link
Member
@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge when green.

@qinhanmin2014 qinhanmin2014 merged commit eeee6a5 into scikit-learn:master Jul 14, 2018
@amueller
Copy link
Member

This is not the right fix and is likely to lead to performance issues, I think. You shouldn't use the numpy function in cython code, you should be using libc.math.log1p (still profiling though)

This was referenced Aug 17, 2018
Closed
Merged
@qinhanmin2014 qinhanmin2014 mentioned this pull request Aug 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meetnaren @qinhanmin2014 @amueller @jnothman
0