10000 [MRG+1] FIX doctests I broke in merging #11180 by jnothman · Pull Request #11318 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG+1] FIX doctests I broke in merging #11180 #11318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2018
Merged

[MRG+1] FIX doctests I broke in merging #11180 #11318

merged 1 commit into from
Jun 20, 2018

Conversation

jnothman
Copy link
Member

Checking for a green tick

@jnothman
Copy link
Member Author

This just skips tests reliant on fetch_mldata, which sometimes fails on CI.

@jnothman
Copy link
Member Author

It turns out the issue was having to point the fixtures at index.rst

@jnothman jnothman mentioned this pull request Jun 19, 2018
Merged
qinhanmin2014
qinhanmin2014 approved these changes Jun 19, 2018
View reviewed changes
Copy link
Member
@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm wondering whether we need to add or is_index everywhere (seems that only adding it to setup_mldata() is enough?)

@qinhanmin2014 qinhanmin2014 changed the title FIX doctests I broke in merging #11180 [MRG+1] FIX doctests I broke in merging #11180 Jun 19, 2018
This was referenced Jun 19, 2018
Merged
Merged
@jnothman jnothman merged commit 02fad7a into scikit-learn:master Jun 20, 2018
@jnothman
Copy link
Member Author

I think we're best off just keeping it working the way it used to.

georgipeev pushed a commit to georgipeev/scikit-learn that referenced this pull request Jun 20, 2018
@jnothman
Fix skipping in conftest.py (scikit-learn#11318)
2ce21c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnothman @qinhanmin2014
0